Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests don't run for deduplicate macro #579

Closed
dbeatty10 opened this issue May 11, 2022 · 0 comments · Fixed by #580
Closed

Tests don't run for deduplicate macro #579

dbeatty10 opened this issue May 11, 2022 · 0 comments · Fixed by #580
Assignees
Labels
bug Something isn't working

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented May 11, 2022

Describe the bug

This is one instance within #558

The deduplicate macro is untested because this code refers to test_dedupe rather than test_deduplicate:

  - name: test_dedupe
    tests:
      - dbt_utils.equality:
          compare_model: ref('data_deduplicate_expected')

Steps to reproduce

cd integration_tests
dbt build --select +test_dedupe

or

cd integration_tests
dbt build --select +test_deduplicate

Expected results

The relevant test would run.

Actual results

Neither example runs the relevant test.

For the first example, it gives this warning:

01:40:33  [WARNING]: Test 'test.dbt_utils_integration_tests.dbt_utils_equality_test_dedupe_ref_data_deduplicate_expected_.2275e15126' (models/sql/schema.yml) depends on a node named 'test_dedupe' which was not found

Are you interested in contributing the fix?

I'm your huckleberry.

@dbeatty10 dbeatty10 added bug Something isn't working triage and removed triage labels May 11, 2022
@dbeatty10 dbeatty10 self-assigned this May 11, 2022
@dbeatty10 dbeatty10 mentioned this issue May 11, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant