Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase threads for Integration Test suite #315

Closed
clausherther opened this issue Dec 24, 2020 · 2 comments · Fixed by #316
Closed

Increase threads for Integration Test suite #315

clausherther opened this issue Dec 24, 2020 · 2 comments · Fixed by #316
Labels
enhancement New feature or request triage

Comments

@clausherther
Copy link
Contributor

clausherther commented Dec 24, 2020

Describe the feature

Currently integration tests run on 1 thread; this causes the integration test models and schema tests to run very slowly, particularly on Snowflake and BigQuery where a higher thread count would speed things up (and potentially save $ on Snowflake compute).
See:

image

I propose increasing the threads to 4 or even higher, e.g. 8, for Snowflake and BigQuery integration tests.

Who will this benefit?

Anyone submitting PRs and the FA team if this ends up saving Snowflake compute cost.

Are you interested in contributing this feature?

Yes

@clausherther clausherther added enhancement New feature or request triage labels Dec 24, 2020
@clrcrl
Copy link
Contributor

clrcrl commented Jan 4, 2021

@jtcohen6 — as guardian of the testing warehouses, do you foresee any issues with this? I think it sounds great! I'd also love to figure out if we can have the different warehouse test jobs running in parallel too, which would considerably speed things up :)

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jan 4, 2021

do you foresee any issues with this?

nope!

I'd also love to figure out if we can have the different warehouse test jobs running in parallel too, which would considerably speed things up :)

agreed—this is possible by switching the CircleCI config to use workflows instead of jobs. I could open a PR for that (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants