Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative MFA devices / solutions are not supported, the script does not fail nicely in cases where such devices are configured as MFA on AWS side #15

Open
xylix opened this issue Mar 4, 2021 · 2 comments

Comments

@xylix
Copy link

xylix commented Mar 4, 2021

AWS cloud supports multiple sorts of MFA devices, for example Yubikeys. The acquire code implementation of AWSMFA does not support any such devices

while token_code is None or len(token_code) != 6:
.

If such devices are not planned to be supported, I think adding a validation for a supported MFA method here

serial_number = find_mfa_for_user(args.serial_number, session, session3)
would make sense. Also the while loop at line 170 of main.py could also output an error for the user if the entered token is over 6 characters long.

If such devices could be supported (for example yubikey could be supported with an optional dependency to python-yubico, or even with some custom code) that would be great (and I could maybe look into adding some support for my devices in a PR).

@dcoker
Copy link
Owner

dcoker commented Mar 6, 2021

Hi Xylix! I would be happy to review PRs that bring the tool up to date on the new features of the related AWS APIs and improve input validation. Thanks!

@xylix
Copy link
Author

xylix commented Mar 8, 2021

Cool! I'll try to get a PR up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants