Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cutoff Frequency Range #7

Open
martinfinke opened this issue Dec 15, 2015 · 3 comments
Open

Cutoff Frequency Range #7

martinfinke opened this issue Dec 15, 2015 · 3 comments

Comments

@martinfinke
Copy link

What's the correct input range for SetCutoff? It seems to be different across the various sub-classes of LadderFilterBase. For example, I tried passing values between 0..20000 to ImprovedMoog::SetCutoff, and it only works for the "middle range", whereas it outputs noise and loud clicks for very high and low frequencies.

What am I supposed to pass to ImprovedMoog::SetCutoff?

@ddiakopoulos
Copy link
Owner

They all should be a cutoff frequency in hz. ImprovedMoog has a suspicious-looking filter response in the existing implementation, but it is also matches the algorithm mentioned in the paper. A trivial multiplication by 2 in computing the c value in SetCutoff will correct the low/high clicks and noise, but I still need to look why ImprovedMoog's response graph is so different from the others.

@martinfinke
Copy link
Author

Multiplyingc by 2 in ImprovedMoog::SetCutoff does not solve the problem here..

Passing 0..20000 to RKSimulationMoog::SetCutoff works in the low/middle range, but results in loud noise towards 20000 Hz.

@iiphii
Copy link

iiphii commented Jan 23, 2016

Using a sample rate of 96 kHz fixed this issue for me. That is the sample rate they used for the evaluation in the original research paper too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants