Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen rendering #248

Closed
tobiasolof opened this issue Sep 12, 2024 · 4 comments · Fixed by #258
Closed

Fullscreen rendering #248

tobiasolof opened this issue Sep 12, 2024 · 4 comments · Fixed by #258

Comments

@tobiasolof
Copy link

Has paging been considered so that the terminal view remains unchanged after exiting?

@ddworken
Copy link
Owner

Hey, thanks for the feature request! Honestly, I haven't thought about this before, but my gut reaction is that paging isn't needed since:

  1. Users can always refine their search query to get to the point where all the results show up on the first page
  2. Users can also run hishtory config-set filter-duplicate-commands true to remove duplicate commands in case that is the cause of there being too many matching entries

Though I'm also not opposed to this feature request if people are interested in this. @tobiasolof WDYT, do you still think this would be a useful feature? I'm also happy to leave this open so that if anyone else is interested they can leave a comment here.

@GRbit
Copy link
Contributor

GRbit commented Sep 16, 2024

@tobiasolof what do you mean exactly by pagination? Currently I can use PgDown and PgUp in search mode. Is there something specific about "the terminal view remains unchanged after exiting"? For me after exiting terminal view remains unchaged

term

@tobiasolof
Copy link
Author

Yeah sorry, maybe I should've been a little more elaborate. I mean to open in a new view, similar to how e.g. nano opens, so that it doesn't "flush" lines in my terminal after exiting. Currently, if I have a low terminal window/pane (few rows) and all rows but the last show output history before entering hiSHtory, it will have fed new lines so that I have to scroll up in order to see that same output history after exiting. Does that make it more clear?

@ddworken ddworken changed the title Paging Fullscreen rendering Oct 19, 2024
@ddworken
Copy link
Owner

Ah got it, thanks for the explanation! That makes perfect sense. I added it behind an opt-in config option (now documented in the README), please give it a shot and let me know if you have any other feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants