-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors on Go 1.11 #23
Comments
I'm really curious as to why goloader breaks in Go 1.11, as the moduledata struct shouldn't have been modified... |
@dearplain do you have any plans on updating this package? |
@dobegor No. Unfortunately, I don't have time to maintain this project. |
It is probably related to the change: golang/go@9f95c9d#diff-13e58c7b55d786f6adf3ea94bad47ccd |
@capnspacehook I try to fix the error, push a commit pkujhd/goloader@6a48a78, |
有没有高手继续修正支持1.13的? |
可以用go自带的plugin模式替代吗 |
可以,但是自带的plugin无法unload,如果加载很多不同的.so的话,会导致内存增加过多 |
i already fix bugs on golang1.13, always only test on Linux. you can checout it https://github.com/pkujhd/goloader |
thanks very much! 高手啊 |
@dearplain Would you consider archiving this repository and redirecting to https://github.com/pkujhd/goloader, who seems to have taken over maintenance of this project? I nearly overlooked the fact that this up-to-date fork exists! @pkujhd Thanks for doing this. 🙂 |
@lthibault With pleasure |
As you probably saw in the Travis builds, something isn't quite right when using Goloader with Go 1.11. Here is the output of running the 'base' example with the example loader:
I'm posting the log from the Travis build because I'm on mobile atm, but I have tried it on my own box with Go 1.11 on Windows and gotten exactly the same result.
The text was updated successfully, but these errors were encountered: