Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on Go 1.11 #23

Open
capnspacehook opened this issue Jan 7, 2019 · 12 comments
Open

Errors on Go 1.11 #23

capnspacehook opened this issue Jan 7, 2019 · 12 comments

Comments

@capnspacehook
Copy link

As you probably saw in the Travis builds, something isn't quite right when using Goloader with Go 1.11. Here is the output of running the 'base' example with the example loader:


unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

unknown gcobj: 

Load error: offset overflow sym: runtime.writeBarrier 

{1 2}

{1 2} &{1 2} {1 0} {0 0}

main.Vertex{X:1, Y:2} &main.Vertex{X:1, Y:2} main.Vertex{X:1, Y:0} main.Vertex{X:0, Y:0}

print &{1 2}

[John Paul George Ringo]

[{2 true} {3 false}]

map[Bell Labs:{40 -74} Google:{37 -122}]

Don't know type string

I'm a bool

runtime stack:

runtime.Stack.func1()

	/home/travis/.gimme/versions/go1.11.2.linux.amd64/src/runtime/mprof.go:798 +0xdd

goroutine 1 [running]:

runtime.systemstack_switch()

	/home/travis/.gimme/versions/go1.11.2.linux.amd64/src/runtime/asm_amd64.s:311 fp=0xc000381528 sp=0xc000381520 pc=0x4560e0

runtime.Stack(0xc0000e8400, 0x400, 0x400, 0xc0000e8400, 0x400)

	/home/travis/.gimme/versions/go1.11.2.linux.amd64/src/runtime/mprof.go:790 +0xec fp=0xc000381598 sp=0xc000381528 pc=0x42746c

<autogenerated>(...)

	/home/travis/gopath/src/github.com/dearplain/goloader/examples/base/base.go:115

fatal error: index out of range

panic during panic

runtime stack:

runtime.Stack.func1()

	/home/travis/.gimme/versions/go1.11.2.linux.amd64/src/runtime/mprof.go:798 +0xdd

I'm posting the log from the Travis build because I'm on mobile atm, but I have tried it on my own box with Go 1.11 on Windows and gotten exactly the same result.

@capnspacehook
Copy link
Author

I'm really curious as to why goloader breaks in Go 1.11, as the moduledata struct shouldn't have been modified...

@dobegor
Copy link

dobegor commented May 16, 2019

@dearplain do you have any plans on updating this package?

@dearplain
Copy link
Owner

@dobegor No. Unfortunately, I don't have time to maintain this project.

@typeless
Copy link

typeless commented May 22, 2019

It is probably related to the change: golang/go@9f95c9d#diff-13e58c7b55d786f6adf3ea94bad47ccd

@pkujhd
Copy link

pkujhd commented Jul 31, 2019

@capnspacehook I try to fix the error, push a commit pkujhd/goloader@6a48a78,
but only test on Linux

@hepking
Copy link

hepking commented Sep 29, 2019

有没有高手继续修正支持1.13的?

@Jakegogo
Copy link

Jakegogo commented Oct 3, 2019

可以用go自带的plugin模式替代吗

@pkujhd
Copy link

pkujhd commented Oct 8, 2019

可以用go自带的plugin模式替代吗

可以,但是自带的plugin无法unload,如果加载很多不同的.so的话,会导致内存增加过多

@pkujhd
Copy link

pkujhd commented Oct 8, 2019

有没有高手继续修正支持1.13的?

i already fix bugs on golang1.13, always only test on Linux. you can checout it https://github.com/pkujhd/goloader

@hepking
Copy link

hepking commented Dec 27, 2019

有没有高手继续修正支持1.13的?

i already fix bugs on golang1.13, always only test on Linux. you can checout it https://github.com/pkujhd/goloader

thanks very much! 高手啊

@lthibault
Copy link

lthibault commented Apr 7, 2020

有没有高手继续修正支持1.13的?

i already fix bugs on golang1.13, always only test on Linux. you can checout it https://github.com/pkujhd/goloader

@dearplain Would you consider archiving this repository and redirecting to https://github.com/pkujhd/goloader, who seems to have taken over maintenance of this project?

I nearly overlooked the fact that this up-to-date fork exists!

@pkujhd Thanks for doing this. 🙂

@pkujhd
Copy link

pkujhd commented May 26, 2020

有没有高手继续修正支持1.13的?

i already fix bugs on golang1.13, always only test on Linux. you can checout it https://github.com/pkujhd/goloader

@dearplain Would you consider archiving this repository and redirecting to https://github.com/pkujhd/goloader, who seems to have taken over maintenance of this project?

I nearly overlooked the fact that this up-to-date fork exists!

@pkujhd Thanks for doing this. 🙂

@lthibault With pleasure
I have fixed some bugs on golang 1.11, and release tag 0.0.3, you should update it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants