Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple assignments #30

Open
brcnblc opened this issue Feb 7, 2019 · 4 comments
Open

Multiple assignments #30

brcnblc opened this issue Feb 7, 2019 · 4 comments

Comments

@brcnblc
Copy link

brcnblc commented Feb 7, 2019

It would be nice if it supported multiple assignments.
For ex:
dotProp.mset (state, {path1 : value1, path2 : value2})

@hilleer hilleer self-assigned this Aug 23, 2019
@hilleer hilleer removed their assignment Jan 30, 2020
@gsouf
Copy link

gsouf commented May 31, 2020

Maybe like #16

@hilleer
Copy link
Member

hilleer commented Jun 12, 2020

Hi @gsouf ,

I will try to have a look into that ASAP. Thanks for the suggestion.

@gsouf
Copy link

gsouf commented Jun 12, 2020

@hilleer thanks for output would be nice if multiple assignement was optimized in order not to recreate the whole object everytime. We have had some performances issues with that when updating many nested fields on large objects at once. Solved by extracting object and updating them by hand before injecting them again, but we lost the benefit of the ease of use of dot prop.

Do you think there is something we could do for that?

@hilleer
Copy link
Member

hilleer commented Jul 8, 2020

Not sure about that @gsouf. Will have a deeper look into it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants