Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for auto-update #24

Open
nchamo opened this issue Dec 18, 2020 · 6 comments
Open

Add support for auto-update #24

nchamo opened this issue Dec 18, 2020 · 6 comments
Labels

Comments

@nchamo
Copy link
Contributor

nchamo commented Dec 18, 2020

We should add some opt-in auto-update feature that updates the catalyst server when a new version is released.

There are two different types of updates:

  • Updates to the catalyst itself
  • Updates to this repository

Ideally, both would be handled automatically. This might requiere some re-thinking the whole update process

@nchamo nchamo added the enhancement New feature or request label Dec 18, 2020
@menduz
Copy link
Member

menduz commented Dec 18, 2020

Please take a look at what we are doing from the infra side: https://github.com/decentraland/adr/blob/main/docs/ADR-21-update-cycle-of-catalysts.md

It involves us to publish new versions of the images to SNS topics (public topics anyone can subscribe to) and specific code running in crontab (in this repo) to update the catalysts based on SQS topics

@nchamo
Copy link
Contributor Author

nchamo commented Dec 18, 2020

Interesting. The only thing I see missing is the possibility of having changes in this repo update themselves too. If not done correctly, then it could lead to some issues, but we might mitigate that by identifying breaking of non-breaking changes, and have the automatic update depend on that.

Ideally, we would stop having people use the repository directly, and make it "more like a product/library".

@agusaldasoro
Copy link
Contributor

My two cents here: it would be nice to have the catalyst in .zone able to auto-update to the next version also.

@menduz
Copy link
Member

menduz commented May 7, 2021

We could do it effortlessly, the only thing to do it is to send an SNS notification to the topic arn:aws:sns:us-east-1:619079673649:decentraland-catalyst-latest-version

@nchamo
Copy link
Contributor Author

nchamo commented May 12, 2021

We would also need decentraland/catalyst#450, right?

@menduz
Copy link
Member

menduz commented Jun 7, 2021

Disregard SQS solution, investigate ways to update all catalysts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants