You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We are using decentraland-ui for the Governance DAO project, and with @andyesp we noticed there is an inconsistency regarding how mobile/tablet styling is calculated.
Particularly for the Tabs.css, the way that mobile is determined is by querying for a max-width: 768px.
In the same project you are also defining a hook in Media.ts, useMobileMediaQuery, which uses a max-width of 767px for determining if something is mobile.
This causes for an unexpected behavior when switching to a tablet view with 768px, where some components display for tablet, but some styles are still applied as if they were mobile.
We suggest:
Change Tabs.css media query to max-width: 767px
Review and update all max-width: 768px media queries
If you agree that this is an issue, we can open a PR with the proposed solution.
The text was updated successfully, but these errors were encountered:
We are using decentraland-ui for the Governance DAO project, and with @andyesp we noticed there is an inconsistency regarding how mobile/tablet styling is calculated.
Particularly for the Tabs.css, the way that mobile is determined is by querying for a
max-width: 768px
.In the same project you are also defining a hook in Media.ts,
useMobileMediaQuery
, which uses amax-width
of767px
for determining if something is mobile.This causes for an unexpected behavior when switching to a tablet view with
768px
, where some components display for tablet, but some styles are still applied as if they were mobile.We suggest:
Tabs.css
media query tomax-width: 767px
max-width: 768px
media queriesIf you agree that this is an issue, we can open a PR with the proposed solution.
The text was updated successfully, but these errors were encountered: