Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add utility icon to IconBadge #534

Merged
merged 1 commit into from
May 3, 2024
Merged

feat: Add utility icon to IconBadge #534

merged 1 commit into from
May 3, 2024

Conversation

LautaroPetaccio
Copy link
Contributor

@LautaroPetaccio LautaroPetaccio commented May 3, 2024 •
edited
Loading

This PR does the following:

  • Adds the utility icon to the IconBadge component.
  • Changes it from being a div to a span, making it possible to wrap it in an anchor.
  • Allows the component to not include text, making it render only the icon.

@vercel Vercel
Copy link

vercel bot commented May 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
decentraland-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 0:50am

@LautaroPetaccio LautaroPetaccio merged commit 6c3a2b9 into master May 3, 2024
6 checks passed
@LautaroPetaccio LautaroPetaccio deleted the feat/add-utility-icon-to-icon-badge branch May 3, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meelrossi meelrossi meelrossi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LautaroPetaccio @meelrossi