Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformPresentationInput mutates the input object #40

Closed
simonas-notcat opened this issue Jul 2, 2020 · 1 comment · Fixed by #41
Closed

transformPresentationInput mutates the input object #40

simonas-notcat opened this issue Jul 2, 2020 · 1 comment · Fixed by #41
Assignees
@mirceanis
Labels
bug Something isn't working

Comments

@simonas-notcat
Copy link
Contributor

I've created this failing test to show where the problem is.
99b09bd

@mirceanis I eventually got around this problem, by not calling this method directly decentralized-identity/veramo@df40d7e#diff-d76fa3686d6633d10d70955ec9a764daL98
@mirceanis mirceanis added the bug Something isn't working label Jul 2, 2020
@mirceanis
Copy link
Member

nice catch.

@mirceanis mirceanis mentioned this issue Jul 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirceanis mirceanis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix] stop input from being mutated by converter methods decentralized-identity/did-jwt-vc
2 participants
@mirceanis @simonas-notcat