Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export JsonWebKeyInterface #126

Merged
merged 3 commits into from
Mar 29, 2022
Merged

export JsonWebKeyInterface #126

merged 3 commits into from
Mar 29, 2022

Conversation

bshambaugh
Copy link
Contributor

This implements issue #125, exporting the JsonWebKey Interface.

@mirceanis mirceanis mentioned this pull request Mar 29, 2022
Closed
mirceanis
mirceanis approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I added a suggestion to include some inline documentation for the new exported type.

src/resolver.ts Show resolved Hide resolved
mirceanis
mirceanis reviewed Mar 29, 2022
View reviewed changes
src/resolver.ts Outdated Show resolved Hide resolved
@mirceanis mirceanis merged commit 519c8bd into decentralized-identity:master Mar 29, 2022
uport-automation-bot pushed a commit that referenced this pull request Mar 29, 2022
@semantic-release-bot
chore(release): 3.2.0 [skip ci]
9fe7a43 
# [3.2.0](3.1.5...3.2.0) (2022-03-29)

### Features

* export JsonWebKey Interface ([#126](#126)) ([519c8bd](519c8bd)), closes [#125](#125)
@uport-automation-bot
Copy link
Collaborator

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bshambaugh @uport-automation-bot @mirceanis