fix: return non-null DIDDocument on Resolver.resolve() #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirceanis
changed the title
Resolver.resolve()
BREAKING CHANGE: The `Resolver.resolve()` method throws an error (rejects the promise) if the DID document returned by the respective method is `null`. Also, `null` documents are not cached.
mirceanis
force-pushed
the
bugfix/return-type
branch
from
ec94cf2
to
1210e74
Compare
mirceanis
changed the title
Resolver.resolve()DIDDocument on Resolver.resolve()
mirceanis
changed the title
DIDDocument on Resolver.resolve()
uport-automation-bot
pushed a commit
that referenced
this pull request
Jun 10, 2020
# [2.0.0](1.1.0...2.0.0) (2020-06-10) ### Bug Fixes * return non-nullable DIDDocument on `Resolver.resolve()` ([#21](#21)) ([2753e3e](2753e3e)) ### BREAKING CHANGES * The `Resolver.resolve()` method throws an error (rejects the promise) if the DID document returned by the respective method is `null`. Also, `null` documents are not cached.
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The
Resolver.resolve()will nowPromise.reject()if the DID document returned by the registered method isnull.