feat(vmcpu): added vmcpu resource and controller #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isteb4k
force-pushed
the
feat/vmcpu
branch
5 times, most recently
from
6680c21
to
52b7da3
Compare
Isteb4k
force-pushed
the
feat/vmcpu
branch
6 times, most recently
from
c99b495
to
4adbf43
Compare
Isteb4k
force-pushed
the
feat/vmcpu
branch
3 times, most recently
from
86d7b42
to
8f6013b
Compare
yaroslavborbat
requested changes
Mar 15, 2024
images/virtualization-artifact/pkg/controller/cpu/cpu_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cpu/cpu_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/api/core/v1alpha2/virtual_machine_cpu_model.go
Outdated
Show resolved
Hide resolved
diafour
reviewed
Mar 20, 2024
Isteb4k
force-pushed
the
feat/vmcpu
branch
2 times, most recently
from
f729f9a
to
421bf38
Compare
diafour
requested changes
Mar 20, 2024
images/virtualization-artifact/pkg/controller/cpu/cpu_webhook.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/cpu/cpu_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm_reconciler_test.go
Outdated
Show resolved
Hide resolved
diafour
approved these changes
Mar 21, 2024
yaroslavborbat
approved these changes
Mar 21, 2024
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
Signed-off-by: Isteb4k <[email protected]>
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added VirtualMachineCPUModel (vmcpu) resource and controller
Refactored vmattachee - moved the disk/image/cpu-specific code from the vmattachee package (open for extensions, closed for modifications principle)
Why do we need it, and what problem does it solve?
PR provides ability to create virtual machines with the required virtual CPU model
What is the expected result?
Resources in cluster: virtualmachinecpumodel.virtualization.deckhouse.io
Controller works with this resource
Ability to bound vmcpu to virtual machine throw vm.spec.cpu.model
Checklist