Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vm,vmip): improve VMIP management #374

Merged
merged 31 commits into from
Sep 25, 2024
Merged

fix(vm,vmip): improve VMIP management #374

merged 31 commits into from
Sep 25, 2024

Conversation

LopatinDmitr
Copy link
Contributor

@LopatinDmitr LopatinDmitr commented Sep 17, 2024 •
edited by fl64
Loading

Description

This PR introduces several critical fixes and enhancements to the VirtualMachine controller and VirtualMachineIPAddress management, including:

  • Fix IP address updates for running VirtualMachines.
  • Add 'Attached' phase for VirtualMachineIPAddress.
  • Enable automatic IP assignment when switching a VirtualMachine from a specified IP to none.
  • Allow multiple VirtualMachines to share the same IP address, with the first one occupying it and others in 'Pending' - state until the IP is available.
  • Improve condition values in the VirtualMachine controller for more accurate state management.
  • Add indexing for VirtualMachineIPAddress resources to improve discovery efficiency.
  • Remove VirtualMachine name labels from VirtualMachineIPAddress resources.

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@LopatinDmitr LopatinDmitr force-pushed the fix/vm/change-ip-for-running-vm branch 3 times, most recently from 5dccee2 to 081ac7e Compare September 17, 2024 10:25
@LopatinDmitr LopatinDmitr force-pushed the fix/vm/change-ip-for-running-vm branch 2 times, most recently from 62fd7c7 to 4d63ac8 Compare September 19, 2024 13:24
@LopatinDmitr
fix(vm): change ip for running vm
402a7a5 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
02c7db4 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
1767eb9 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
0291d14 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
da6cd8b 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
d7b2086 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
b8a8c48 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
004b759 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
a696677 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
a7999da 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
76d9689 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): change ip for running vm
36e6236 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix(vm): add deleting vmip from spec for running vm
11a7436 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
test
964e9ab 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
test
c5afdae 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
++
8ca2c40 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
++
3e63e45 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix
63fe42e 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix
a1ada4e 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
experiment
1d63f9f 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix
0fab51d 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix linter
81fdd4b 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
++
e7de081 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
add todo
166d2c7 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr
fix todo
ba8e555 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr LopatinDmitr changed the title fix(vm): change ip for running vm fix(vm,vmip): Improved VMIP Management and Reliability for Running VMs Sep 24, 2024
@LopatinDmitr LopatinDmitr marked this pull request as ready for review September 24, 2024 18:06
@fl64 fl64 changed the title fix(vm,vmip): Improved VMIP Management and Reliability for Running VMs fix(vm,vmip): improve VMIP management Sep 25, 2024
LopatinDmitr and others added 2 commits September 25, 2024 14:13
@LopatinDmitr @yaroslavborbat
Update images/virtualization-artifact/pkg/controller/vmip/internal/li…
dad3a64 
…fecycle_handler.go

Co-authored-by: Yaroslav Borbat <[email protected]>
Signed-off-by: Dmitry Lopatin <[email protected]>
@LopatinDmitr
fix
42f5225 
Signed-off-by: dmitry.lopatin <[email protected]>
@LopatinDmitr LopatinDmitr merged commit 43b9074 into main Sep 25, 2024
1 check passed
@LopatinDmitr LopatinDmitr deleted the fix/vm/change-ip-for-running-vm branch September 25, 2024 13:58
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Sep 25, 2024
Merged
diafour pushed a commit that referenced this pull request Oct 2, 2024
@LopatinDmitr @diafour
fix(vm,vmip): improve VMIP management (#374)
d6695ef 
Signed-off-by: dmitry.lopatin <[email protected]>
universal-itengineer pushed a commit that referenced this pull request Oct 14, 2024
@deckhouse-BOaTswain
chore(main): release 0.14.0 (#396)
a4b52fe 
Features
api: move calculation of scratch filesystem overhead to cdi controller (91d8db3)
cvi,vi,vd: replace uploadCommand field with imageUploadURLs (70ccd2e)
kube-api-rewriter: add pprof and metrics, fix rewrite performance (#402) (a009052)
vd, vmbda: add _labels and _annotations metrics (#399) (7690d2b)
vd: resizing vd in filesystem mode (#385) (7857bd3)
vm: add custom secret types for provisioning (#390) (597d551)
vm: add failure message to condition if migration is failed (78b3a42)
vm: add new VM _labels and _annotations metrics and refactor existing ones (#398) (75e57ad)
vmclass: add validation for matching virtual machine sizing policies upon virtual machine class change (#389) (029c445)
vm: disable serial console log (21d0bec)
vmop: add metrics (#370) (2436b8e)
vmop: add operation to migrate vm (#386) (d61bab4)
vmrestore: add the ability to restore virtualmachines (0c59bff)
vmsnapshot: add the ability to snapshot virtualmachines (38b84d4)

Bug Fixes
vd,vi,cvi: fix vd uploader service creating (#409) (d012007)
vd: allow to change size in spec for not ready vd (#411) (38bb0eb)
vm,vmip: improve VMIP management (#374) (d6695ef)
vmbda: reconcile from virtual disk phase changes events (7157204)
vm: fix the virtual machine matching with the virtual machine class during validation when no sizing policy is provided (#431) (4704e31)
vmip: add validating ip address for VMIP with type 'Static' (#404) (2c95be9)
vmip: fix deleting unattached vmip (#405) (56cb6cd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaroslavborbat yaroslavborbat yaroslavborbat approved these changes

Assignees

@LopatinDmitr LopatinDmitr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LopatinDmitr @yaroslavborbat