feat(vmclass): add validation for matching virtual machine sizing policies upon virtual machine class change #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Valeriy Khorunzhin <[email protected]>
added 4 commits
September 19, 2024 12:18
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
eofff
changed the title
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
requested changes
Sep 19, 2024
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/vm_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/vm_reconciler.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Valeriy Khorunzhin <[email protected]>
added 2 commits
September 19, 2024 16:43
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
previously approved these changes
Sep 19, 2024
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
previously approved these changes
Sep 19, 2024
Isteb4k
requested changes
Sep 19, 2024
images/virtualization-artifact/pkg/controller/vm/vm_reconciler.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
Isteb4k
changed the title
Signed-off-by: Valeriy Khorunzhin <[email protected]>
added 4 commits
September 19, 2024 20:06
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Isteb4k
requested changes
Sep 24, 2024
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/validators/sizing_policy_validator.go
Outdated
Show resolved
Hide resolved
added 2 commits
September 24, 2024 11:28
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
requested changes
Sep 24, 2024
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vm/internal/validators/sizing_policy_validator.go
Outdated
Show resolved
Hide resolved
added 2 commits
September 24, 2024 12:57
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
requested changes
Sep 25, 2024
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
Isteb4k
requested changes
Sep 25, 2024
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Show resolved
Hide resolved
added 2 commits
September 25, 2024 12:37
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Isteb4k
previously approved these changes
Sep 25, 2024
yaroslavborbat
requested changes
Sep 25, 2024
images/virtualization-artifact/pkg/controller/vm/internal/size_policy.go
Outdated
Show resolved
Hide resolved
…_policy.go Co-authored-by: Yaroslav Borbat <[email protected]> Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
previously approved these changes
Sep 25, 2024
Signed-off-by: Valeriy Khorunzhin <[email protected]>
yaroslavborbat
approved these changes
Sep 25, 2024
eofff
deleted the
feat/vmclass/check-vms-matched-updated-size-policy
branch
diafour
pushed a commit
that referenced
this pull request
Oct 2, 2024
…icies upon virtual machine class change (#389) A validation has been added to ensure virtual machines match the sizing policies when their virtual machine class is changed. The result of this matching check is also added to the conditions field of the virtual machine.
universal-itengineer
pushed a commit
that referenced
this pull request
Oct 14, 2024
Features api: move calculation of scratch filesystem overhead to cdi controller (91d8db3) cvi,vi,vd: replace uploadCommand field with imageUploadURLs (70ccd2e) kube-api-rewriter: add pprof and metrics, fix rewrite performance (#402) (a009052) vd, vmbda: add _labels and _annotations metrics (#399) (7690d2b) vd: resizing vd in filesystem mode (#385) (7857bd3) vm: add custom secret types for provisioning (#390) (597d551) vm: add failure message to condition if migration is failed (78b3a42) vm: add new VM _labels and _annotations metrics and refactor existing ones (#398) (75e57ad) vmclass: add validation for matching virtual machine sizing policies upon virtual machine class change (#389) (029c445) vm: disable serial console log (21d0bec) vmop: add metrics (#370) (2436b8e) vmop: add operation to migrate vm (#386) (d61bab4) vmrestore: add the ability to restore virtualmachines (0c59bff) vmsnapshot: add the ability to snapshot virtualmachines (38b84d4) Bug Fixes vd,vi,cvi: fix vd uploader service creating (#409) (d012007) vd: allow to change size in spec for not ready vd (#411) (38bb0eb) vm,vmip: improve VMIP management (#374) (d6695ef) vmbda: reconcile from virtual disk phase changes events (7157204) vm: fix the virtual machine matching with the virtual machine class during validation when no sizing policy is provided (#431) (4704e31) vmip: add validating ip address for VMIP with type 'Static' (#404) (2c95be9) vmip: fix deleting unattached vmip (#405) (56cb6cd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A validation has been added to ensure virtual machines match the sizing policies when their virtual machine class is changed. The result of this matching check is also added to the
conditionsfield of the virtual machine.Why do we need it, and what problem does it solve?
What is the expected result?
The matching status of the virtual machine with the sizing policies should be reflected in the corresponding
condition.Checklist