feat(core, kubevirt): disable kubevirt exportproxy #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need more detailed description what is going on here. We already disable exportproxy with |
diafour
previously approved these changes
Nov 2, 2024
Signed-off-by: yaroslavborbat <[email protected]>
yaroslavborbat
force-pushed
the
feat/core/disable-kubevirt-exportproxy
branch
from
46cdaee
to
43601ff
Compare
diafour
approved these changes
Nov 5, 2024
danilrwx
pushed a commit
that referenced
this pull request
Nov 5, 2024
Remove FeatureGate VMExport from kubevirt config. Remove patches related to exportproxy. Signed-off-by: yaroslavborbat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove FeatureGate VMExport from kubevirt config.
Remove patches related to exportproxy.
Why do we need it, and what problem does it solve?
We scaled exportproxy to 0 replicas with patches to disabled unneeded component. Without VMExport feature virt-operator doesn't create Deployment at all.
What is the expected result?
Checklist