Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(vmsnapshot): add the ability to snapshot virtualmachines #347

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(vmsnapshot): add the ability to snapshot virtualmachines #347

wants to merge 2 commits into from

Conversation

Isteb4k
Copy link
Contributor

@Isteb4k Isteb4k commented Sep 5, 2024 •
edited
Loading

Description

New resource VirtualMachineSnapshot:

  1. CRD using kubebuilder, ru version
  2. Controller ensuring the consistency of the virtual machine and block devices when creating a snapshot (Freezing, no RestartAwaitingChanges, management via RequiredConsistency)
  3. Conditions VirtualMachineReady, VirtualMachineSnapshotReady
  4. Management of underlying secret and corresponding virtual disk snapshots.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@Isteb4k Isteb4k changed the title chore(api): set priority class for pods feat(vmsnapshot): create new controller Sep 5, 2024
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 27 times, most recently from 87a5338 to e4f11d7 Compare September 10, 2024 13:59
diafour
diafour reviewed Sep 16, 2024
View reviewed changes
images/virtualization-artifact/pkg/controller/vmsnapshot/internal/watcher/vd_watcher.go
Comment on lines +75 to +82
vdName, ok := strings.CutSuffix(vdSnapshotName, "-"+string(vmSnapshot.UID))
if !ok {
slog.Default().Error("Failed to get virtual disk name from virtual disk snapshot name, please report a bug")
continue
}

if vdName == obj.GetName() {
requests = append(requests, reconcile.Request{
NamespacedName: types.NamespacedName{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set label with VirtualMachineSnapshot name on VirtualDiskSnapshot resources?

@Isteb4k Isteb4k marked this pull request as draft September 19, 2024 09:07
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 17 times, most recently from af1815b to d8d50c6 Compare September 26, 2024 17:44
@Isteb4k Isteb4k force-pushed the feat/vmsnapshot/controller branch 4 times, most recently from 7d1646a to 88a30c3 Compare September 27, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diafour diafour diafour left review comments

@LopatinDmitr LopatinDmitr LopatinDmitr left review comments

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat

At least 1 approving review is required to merge this pull request.

Assignees

@Isteb4k Isteb4k

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isteb4k @diafour @LopatinDmitr