-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cdi): update to v1.60.3 #382
Draft
diafour
wants to merge
35
commits into
main
Choose a base branch
from
refactor/cdi/update-to-1-60
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diafour
commented
Sep 17, 2024
Comment on lines
+5
to
11
@@ -50,6 +50,9 @@ var CapabilitiesByProvisionerKey = map[string][]StorageCapabilities{ | ||
"openshift-storage.cephfs.csi.ceph.com": {{rwx, file}}, | ||
// LINSTOR | ||
"linstor.csi.linbit.com": createAllButRWXFileCapabilities(), | ||
+ // Deckhouse | ||
+ "replicated.csi.storage.deckhouse.io": createLinstorCapabilities(), | ||
+ "replicated.csi.storage.deckhouse.io": createAllButRWXFileCapabilities(), | ||
+ "local.csi.storage.deckhouse.io": createTopoLVMCapabilities(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our block is moved to be closer to LINSTOR to quicker understand what's changed in upstream in the future.
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
2 times, most recently
from
September 19, 2024 12:04
bb6b134
to
5b391eb
Compare
diafour
force-pushed
the
refactor/kubevirt/update-to-1.3.1
branch
2 times, most recently
from
September 24, 2024 19:43
14e4380
to
a320fd9
Compare
An error occurred while trying to automatically change base from
refactor/kubevirt/update-to-1.3.1
to
main
September 26, 2024 14:34
- Remove 006-customizer.patch: it is already in the upstream. - Remove redundant imports reformats. - Optimize 011-change-storage-class-for-scratch-pvc.patch: one line change is required. - Optimize 013-converting-images-on-filesystem-to-qcow2.patch: move new code in a separate file to increase chances to apply without problems in the future. Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
++ remove rpmtrees from bazel builds Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
…Ignore embedded CRDs for prettier. Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
…d binaries, no bundling into images - Update virtualization-artifact dependencies: kubevirt-api and cdi-api Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
- Update kubevirt.io/api to 1.3.1 - Ignore prettier for crds/embedded ++ revert p11 for cdi-apiserver Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
diafour
force-pushed
the
refactor/cdi/update-to-1-60
branch
from
September 26, 2024 15:35
f3dd568
to
1ee4176
Compare
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
++ add build without bazel Signed-off-by: Ivan Mikheykin <[email protected]>
++ add build without bazel ++ add custom-build dir to git Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
universal-itengineer
added
the
build/self-hosted/virt-runners
Run jobs on virtualization git hub runners
label
Sep 27, 2024
- Small refinements in dvcr artifact. - Use Scratch for static binaries: cdi-operator, cdi-apiserver, cdi-controller, cdi-uploadproxy. - Update cdi API Go module in virtualization-artifact. Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Signed-off-by: Ivan Mikheykin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist