Pre-commit.ci failure due to permission denied

[maki49]

Up to now I find it only happens in @PeizeLin 's PR (like #4558 and #4590), so I guess it is because his repository is forked from abacusmodeling rather than deepmodeling. This problem should not block the merge.

[caic99]

Hi @maki49 ,
Running pre-commit.ci services requires access to that repo, so your guess is possibly correct. We've asked the user to fork the repo from the deepmodeling community. And since pre-commit is not an action required to be passed, it is not blocking the merging progress.

[mohanchen]

Besides the solution you just provided, there is still an issue remains. Apparently, from the point of code reviewer, any PRs that failed the pre-commit is labelled as 'failed PR', making the reviewer very confusing. What's your suggestion to deal with this situation? @caic99

[caic99]

@mohanchen From the view of the person who decides whether to merge that PR, the PR status page shows:
i. squash and merge, which means the required actions are passed and there is at least 1 approving review, or
ii. merging is blocked, which the condition above is not satisfied.
I think these info is sufficient for them.

[caic99]

@mohanchen Or, the reviewer can request the developer to submit a PR from a repo forked from deepmodeling repo, ensuring the correctness.

[mohanchen]

Thanks!