Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tests to check roles in responses of Chat Generators #1048

Closed
Amnah199 opened this issue Sep 4, 2024 · 0 comments · Fixed by #1090
Closed

Add new tests to check roles in responses of Chat Generators #1048

Amnah199 opened this issue Sep 4, 2024 · 0 comments · Fixed by #1090
Assignees
@Amnah199
Labels
feature request Ideas to improve an integration P1

Comments

@Amnah199
Copy link
Contributor

Amnah199 commented Sep 4, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
Test coverage of roles and formatting of responses in chat generators is currently limited. This was highlighted in this PR.

Describe the solution you'd like
Add new tests to verify:

  • Correct role handling in ChatMessage in chat interactions.
  • Consistent formatting of ChatMessage responses.

Additional context:
GoogleAIGeminiChatGenerator was returning ChatMessage responses with incorrect roles which went unnoticed because of missing tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Amnah199 Amnah199

Labels
feature request Ideas to improve an integration P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add chatrole tests and meta for GeminiChatGenerators deepset-ai/haystack-core-integrations
2 participants
@julian-risch @Amnah199