Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin protobuf version in google_vertex integration #1051

Closed
silvanocerza opened this issue Sep 5, 2024 · 2 comments · Fixed by #1085
Closed

Unpin protobuf version in google_vertex integration #1051

silvanocerza opened this issue Sep 5, 2024 · 2 comments · Fixed by #1085
Labels
bug Something isn't working integration:google-vertex

Comments

@silvanocerza
Copy link
Contributor

We had to pin protobuf in the google_vertex integration as a workaround to this bug in the proto-plus library.

When that is fixed we should remove the version pin and make sure everything works correctly.
@silvanocerza silvanocerza added bug Something isn't working integration:google-vertex labels Sep 5, 2024
@silvanocerza
Copy link
Contributor Author

Version has been pinned with #1050

@silvanocerza
Copy link
Contributor Author

Issue has been fixed, waiting for release.

@silvanocerza silvanocerza mentioned this issue Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working integration:google-vertex
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Unpin protobuf dependency in Google Vertex integration deepset-ai/haystack-core-integrations
1 participant
@silvanocerza