Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Vertex AI integration #115

Closed
10 tasks done
Tracked by #6667
silvanocerza opened this issue Dec 18, 2023 · 2 comments
Closed
10 tasks done
Tracked by #6667

Google Vertex AI integration #115

silvanocerza opened this issue Dec 18, 2023 · 2 comments
Assignees
Labels
integration:google-vertex new integration Discuss the creation of a new integration in Core P1

Comments

@silvanocerza
Copy link
Contributor

silvanocerza commented Dec 18, 2023

Summary and motivation

This already mostly implemented but I'm creating this issue to track the remaining work.

Checklist

If the request is accepted, ensure the following checklist is complete before closing this issue.

@masci masci added integration:google-vertex new integration Discuss the creation of a new integration in Core labels Dec 18, 2023
@mathislucka mathislucka added this to the 2.0 Generators milestone Dec 22, 2023
@mathislucka mathislucka added the P1 label Dec 22, 2023
@TuanaCelik
Copy link
Member

@silvanocerza @masci - since we're also creating an integration directly to Gemini, and as far as we understand this integration has been only to access Gemini models via VertexAI/GCP, does it make more sense to name the generator VertexAIGeminiGenerator in this integration instead of GeminiGenerator?

-- question from @deepset-ai/devrel collectively

@TuanaCelik
Copy link
Member

@silvanocerza @dfokina we've created an issue for docs and assigned Daria for now, if that's helpful to track. But I think you should be in touch about the naming of the components here as there's a separate similar integration coming for Makersuite which means the GeminiGenerator might change names

@masci masci closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:google-vertex new integration Discuss the creation of a new integration in Core P1
Projects
None yet
Development

No branches or pull requests

4 participants