Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the list of supported (chat) generators in langfuse for custom generators #1153

Open
alex-stoica opened this issue Oct 24, 2024 · 0 comments
Labels
feature request Ideas to improve an integration integration:langfuse

Comments

@alex-stoica
Copy link

Is your feature request related to a problem? Please describe.
A custom component might have the correct output to allow for integrations/langfuse/src/haystack_integrations/tracing/langfuse/tracer.py to work. However, because the generators list is structured as follows:

_SUPPORTED_GENERATORS = [
    ...
]
_SUPPORTED_CHAT_GENERATORS = [
    ...
]
_ALL_SUPPORTED_GENERATORS = _SUPPORTED_GENERATORS + _SUPPORTED_CHAT_GENERATORS

it will not work with tracing unless the custom component is incorrectly placed into one of these predefined categories, which is not an ideal or fitting solution

Describe the solution you'd like
A function like register_generator_for_tracing could be created, with a parameter to specify whether the generator is a chat generator or not. This function would also check whether the output format meets a certain standard before registering the generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Ideas to improve an integration integration:langfuse
Projects
None yet
Development

No branches or pull requests

2 participants