Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ollama Generator #146

Closed
10 tasks done
Tracked by #6667
anakin87 opened this issue Dec 22, 2023 · 11 comments
Closed
10 tasks done
Tracked by #6667

Add Ollama Generator #146

anakin87 opened this issue Dec 22, 2023 · 11 comments
Assignees
Labels
new integration Discuss the creation of a new integration in Core P2

Comments

@anakin87
Copy link
Member

anakin87 commented Dec 22, 2023

Summary and motivation

See deepset-ai/haystack#6514

Detailed design

See deepset-ai/haystack#6514

Checklist

If the request is accepted, ensure the following checklist is complete before closing this issue.

  • The code was merged in the main branch
  • Docs are published at https://docs.haystack.deepset.ai/
  • There is a Github workflow running the tests for the integration nightly and at every PR
  • A label named like integration:<your integration name> has been added to this repo
  • The labeler.yml file has been updated
  • The package has been released on PyPI
  • An integration tile has been added to https://github.com/deepset-ai/haystack-integrations
  • The integration has been listed in the Inventory section of this repo README
  • There is an example available to demonstrate the feature
  • The feature was announced through social media
@anakin87 anakin87 added new integration Discuss the creation of a new integration in Core P2 labels Dec 22, 2023
@anakin87 anakin87 self-assigned this Dec 27, 2023
@anakin87
Copy link
Member Author

anakin87 commented Jan 3, 2024

Features to add to this integration in the future (taking notes here, but should open issues):

  • streaming support
  • ChatGenerator

@anakin87
Copy link
Member Author

anakin87 commented Jan 3, 2024

@AlistairLR112 we can continue working on this integration, using the checklist above.
I can work on drafting docs, in collaboration with the documentation team.

You can choose what you want:

Of course, if you don't have time, I'll take care of it...

FYI @bilgeyucel @dfokina

@AlistairLR112
Copy link
Contributor

Am happy to take it on :)

@AlistairLR112
Copy link
Contributor

Example started here: #170

@AlistairLR112
Copy link
Contributor

Tile added: deepset-ai/haystack-integrations#108

@dfokina
Copy link
Contributor

dfokina commented Jan 5, 2024

Docs are published: https://docs.haystack.deepset.ai/v2.0/docs/ollamagenerator

@AlistairLR112
Copy link
Contributor

AlistairLR112 commented Jan 5, 2024

Hello everyone, one thing I have noticed we need to add in the docs and the example is the mapping of the volumes in docker - this has already been done in the CI pipeline

We need to add -v ollama:/root/.ollama to the docker run command

It won't affect any functionality

Needs to be added to the following:

https://github.com/deepset-ai/haystack-integrations/blob/a15e09d3997548a1f8b8cab5fce2416537822757/integrations/ollama.md?plain=1#L61

https://github.com/deepset-ai/haystack-core-integrations/blob/fae1e366372ba89bd4b469604f1c24520c69d789/integrations/ollama/example/example.py?plain1#L5

@anakin87
Copy link
Member Author

anakin87 commented Jan 5, 2024

@AlistairLR112 please correct me if I am wrong.
This is only needed to create a persistent volume for Ollama.

@AlistairLR112
Copy link
Contributor

Ah whoops, you are right, was thinking it was mapping the entrypoint!

False alarm!!!

@anakin87
Copy link
Member Author

anakin87 commented Jan 5, 2024

Opened a PR in Ollama to mention the integration in their README: ollama/ollama#1808

@masci
Copy link
Contributor

masci commented Jan 7, 2024

Why Haystack LLM framework and not just Haystack? https://github.com/jmorganca/ollama/pull/1808/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R302

Can you fix that?

@anakin87 anakin87 closed this as completed Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new integration Discuss the creation of a new integration in Core P2
Projects
None yet
Development

No branches or pull requests

4 participants