Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing command to undo the "build" stage #111

Closed
evelikov opened this issue Nov 20, 2019 · 7 comments
Closed

Missing command to undo the "build" stage #111

evelikov opened this issue Nov 20, 2019 · 7 comments

Comments

@evelikov
Copy link
Collaborator

Currently we have the following pair of commands

add - remove
install - uninstall

With each one recursively calling all the other respective substeps to ensure coherent and symmetric expectations.

So for example if we call:

  • uninstall - the binary artefacts will be purged from kmod visible locations
  • remove - will also erase the binaries produced with build and eradicate the dkms module metadata.

So in the former case, we still have binaries around, while in the latter we cannot re-issue dkms build :-\

Can we get a "unbuild" stage please? I've got a quick and dirty patch which does the job if people are interested.

@evelikov evelikov changed the title Missing comment to undo the "build" stage Missing command to undo the "build" stage Nov 20, 2019
@evelikov
Copy link
Collaborator Author

If I understand the Debian report correctly, #20 was introduced precisely with the above usecase in mind. Mind you that "fix" seemed off, so it was reverted sometimes after with #77.

@superm1
Copy link
Contributor

superm1 commented Nov 20, 2019

@yuzaipiaofei can certainly review a patch if you want to propose one, sure.

@GoPerry
Copy link
Contributor

GoPerry commented Nov 21, 2019

@evelikov welcome your new patch to improve the experience.

@evelikov
Copy link
Collaborator Author

Thanks everyone. I've stumbled a number of bugs along the way, which I'm addressing as part of the MR. I'll send it out in the next couple of days.

@evelikov
Copy link
Collaborator Author

@superm1 @GoPerry MR #117 has been opened.
Any input would be appreciated.

@superm1
Copy link
Contributor

superm1 commented Jan 29, 2020

Once Chinese new year is over @GoPerry should be able to review

@evelikov
Copy link
Collaborator Author

With the MR merged we can close this. Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants