You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PyDelphin still refers to "string" and "grammar" predicates, where these should be "surface" and "abstract" ("string" is compared to "type", not "grammar"/"abstract").
The text was updated successfully, but these errors were encountered:
@mcmillanmajora I had to double-check because "string" and "grammar" don't directly correlate with "surface" and "abstract", but it appears that the code was treating them as equivalent, so it should be safe to just rename one with the other. But in the interest of backward-compatibility, retain the old names as well. E.g.:
classPred(...):
...
ABSTRACT=GRAMMARPRED=0
...
@classmethod@deprecated(final_version='1.0.0', alternative='Pred.abstract()`)defgrammarpred(cls, predstr):
"""Instantiate a Pred from its symbol string."""returncls.abstract(predstr)
@classmethoddefabstract(cls, predstr):
"""Instantiate a Pred from its symbol string."""lemma, pos, sense, _=split_pred_string(predstr)
returncls(Pred.ABSTRACT, lemma, pos, sense, predstr)
...
Also go through and reword docstrings, as appropriate, and unit tests.
PyDelphin still refers to "string" and "grammar" predicates, where these should be "surface" and "abstract" ("string" is compared to "type", not "grammar"/"abstract").
The text was updated successfully, but these errors were encountered: