Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow sending arbitrary options to ACE #149

Closed
goodmami opened this issue Jun 15, 2018 · 2 comments
Closed

Disallow sending arbitrary options to ACE #149

goodmami opened this issue Jun 15, 2018 · 2 comments
Assignees
Milestone

Comments

@goodmami
Copy link
Member

There are some options to ACE that are useful, such as -n and --timeout, but some can break PyDelphin's ability to interpret the results. The useful options could be whitelisted, or they could be made into Python parameters (as is done with tsdbinfo). The latter is easier to validate. Both of these options would require PyDelphin to remain relatively in-sync with recent ACE versions.

Perhaps a compromise is to allow arbitrary options on AceProcess, then restrict them for AceParser, AceTransferer, and AceGenerator. This also makes sense because some options are only relevant for certain tasks, like --show-realization-mrses.

@goodmami goodmami added this to the v0.8.0 milestone Aug 6, 2018
@goodmami goodmami self-assigned this Aug 20, 2018
@goodmami
Copy link
Member Author

I updated http://moin.delph-in.net/AceOptions with the options available in 0.9.27. The "processing" and "performance" options should be safe, but most of the "input/output" and "alternative mode" options need to be blocked or handled specially. The "undocumented" should probably be blocked until their effect is understood.

And I think the blocking should be implemented as a whitelist for cmdargs, rather than using function parameters, as it is less disruptive for existing users and less work for me.

@goodmami
Copy link
Member Author

And I don't think I'll do task-specific options just yet. Irrelevant options should just be ignored by ACE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant