Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMRS.scopal_arguments() gives incorrect target scope labels #249

Closed
goodmami opened this issue Aug 14, 2019 · 0 comments
Closed

DMRS.scopal_arguments() gives incorrect target scope labels #249

goodmami opened this issue Aug 14, 2019 · 0 comments

Comments

@goodmami
Copy link
Member

Related to #248, DMRS.scopal_arguments() sets the target of the scopal argument to an incorrect label when the scopes parameter is used.

These lines:

            target = id_to_lbl.get(link.end, link.end)
            scargs[link.start].append((link.role, relation, label))

... should be:

            target = id_to_lbl.get(link.end, link.end)
            scargs[link.start].append((link.role, relation, target))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goodmami