Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite mrs.is_isomorphic() to avoid NetworkX dependency #263

Closed
goodmami opened this issue Dec 20, 2019 · 1 comment
Closed

Rewrite mrs.is_isomorphic() to avoid NetworkX dependency #263

goodmami opened this issue Dec 20, 2019 · 1 comment
Labels
maintenance improving code quality; not features or bugs
Milestone
v1.1.0

Comments

@goodmami
Copy link
Member

NetworkX is one of the heaviest dependencies of PyDelphin, and it's part of the default install and only used for a single function. If delphin.mrs.is_isomorphic() can be rewritten with its own implementation of isomorphism checking then we can get rid of the dependency.
@goodmami goodmami added the maintenance improving code quality; not features or bugs label Dec 20, 2019
@goodmami
Copy link
Member Author

This was done in 75d1bfa.

@goodmami goodmami added this to the v1.1.0 milestone Dec 20, 2019
@goodmami goodmami closed this as completed Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance improving code quality; not features or bugs
Projects
None yet
Milestone
v1.1.0
Development

No branches or pull requests
1 participant
@goodmami