Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Penman encoding errors are not caught by PyDelphin #266

Closed
goodmami opened this issue Jan 14, 2020 · 0 comments
Closed

Penman encoding errors are not caught by PyDelphin #266

goodmami opened this issue Jan 14, 2020 · 0 comments
Labels
Milestone

Comments

@goodmami
Copy link
Member

When doing a delphin convert operation, PyDelphin errors (if any) are caught and logged and then conversion proceeds. If there's a PenmanError when converting to/from dmrs-penman or eds-penman, the error is not caught and conversion stops.

A solution is to catch these errors where they occur and wrap them in a PyDelphinException so they are catchable by other parts of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant