Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send ad-hoc stickers as stickers #2254

Open
r10s opened this issue Aug 2, 2024 · 1 comment
Open

send ad-hoc stickers as stickers #2254

r10s opened this issue Aug 2, 2024 · 1 comment
Labels

Comments

@r10s
Copy link
Member

r10s commented Aug 2, 2024

iOS allows to create a "sticker" from each image by a long tap. with a second finger, you can then navigate to Delta Chat and send that. unfortunately as non-transparent image and not as sticker:

RPReplay_Final1722598584.MOV

these stickers were used to be sent as stickers, however, because of #2128 we decided to stage images if in doubt - which is still the better approach.

still, it we can improve the detection of a "sticker", which is currently only by size. instead/additionally, we can check if eg. corner pixels are transparent and assume a sticker in that case.

this was already suggested, however, postponed until we see it is really needed, which is the case now

EDIT: that does not seem to be directly related, see below

@r10s r10s added the bug label Aug 2, 2024
@r10s
Copy link
Member Author

r10s commented Aug 2, 2024

hm, seems not to be related to the detection of #2128 , that code path seems not to be executed when dropping an image that way. still, would be interesting which code path is involved there and if we can tweak things easily there.

the detection of #2128 is working as expected when having added the image as a sticker before:

RPReplay_Final1722600093.mov

@zeitschlag zeitschlag assigned zeitschlag and unassigned zeitschlag Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants