Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatibility with Cloudflare due to using assert instead of node:assert #346

Closed
SavaCool122 opened this issue Feb 16, 2024 · 3 comments · Fixed by #347
Closed

Incompatibility with Cloudflare due to using assert instead of node:assert #346

SavaCool122 opened this issue Feb 16, 2024 · 3 comments · Fixed by #347

Comments

@SavaCool122
Copy link
Contributor

Cloudflare has support for some Node.js packages (link). There is support for assert package, but as I understand it only with the use of node: prefix (like node:assert). I am not an expert in Node.js , but maybe there is a possibility to add this prefix? I would be happy to do it myself if this option is suitable for CloudFlare support of your codebase.
@mcollina
Copy link
Collaborator

Unfortunately we support some old node versions that do not support the node: prefix. If I get a PR, I'll land it for the next major.

@SavaCool122 SavaCool122 changed the title Incompatibility with CloudFlare due to using assert instead of node:assert Incompatibility with Cloudflare due to using assert instead of node:assert Feb 16, 2024
@SavaCool122
Copy link
Contributor Author

That sounds great to me. I'll be happy to create this PR

@SavaCool122 SavaCool122 mentioned this issue Feb 16, 2024
Merged
@SavaCool122
Copy link
Contributor Author

Here's the PR #347. If any edits are needed, I'd be happy to hear about them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add node: prefix for assert SavaCool122/find-my-way
2 participants
@mcollina @SavaCool122