Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prisma CLI keeps downloading files that should only be downloaded once #20098

Closed
janpio opened this issue Aug 8, 2023 · 3 comments
Closed

Prisma CLI keeps downloading files that should only be downloaded once #20098

janpio opened this issue Aug 8, 2023 · 3 comments
Assignees

Comments

@janpio
Copy link

janpio commented Aug 8, 2023

On installation Prisma CLI (Npm package prisma) downloads some files (some binaries and some Node-API based libraries) from a CDN (binaries.prisma.sh) and puts them in node_modules for later use. prisma -v then outputs the path to these and asks the binaries and Node-API library for their version to output.

In my setup on Windows, each time I run prisma -v it downloads these files again:
image

Reproduction might be as simple as creating a new folder, then running deno run -A npm:prisma init and then deno run -A npm:prisma -v to observe it downloading the file again each time you run the command.

(When running prisma -v I also get this error message regularly when the CLI tries to ask one of the binaries for its version: #19544)

deno --version
deno 1.36.0 (release, x86_64-pc-windows-msvc)
v8 11.6.189.12
typescript 5.1.6
@janpio janpio changed the title Prisma CLI keeps download files that should only be downloaded once Prisma CLI keeps downloading files that should only be downloaded once Aug 8, 2023
@janpio
Copy link
Author

janpio commented Aug 8, 2023

(Sometimes additionally to downloading, also this error is thrown first: #19544 (comment))

@kt3k
Copy link
Member

kt3k commented Nov 24, 2023

We assume this has been fixed in #21297. Could you check the above again with Deno v1.38.3?

@janpio
Copy link
Author

janpio commented Nov 24, 2023

Looks good, it download the engines once and then not any more - as intended. Thanks!

@janpio janpio closed this as completed Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants