Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define is not defined #2613

Closed
jeroenptrs opened this issue Jul 4, 2019 · 4 comments
Closed

define is not defined #2613

jeroenptrs opened this issue Jul 4, 2019 · 4 comments

Comments

@jeroenptrs
Copy link

jeroenptrs commented Jul 4, 2019

What?

I tried running the basic oak example and bundling it.

If I just plainly run it, it works nicely. If I bundle it to a .js file however I get the following when I run it (bundling is successful apparently):

error: Uncaught ReferenceError: define is not defined
► file:///Users/jeroen.peeters/Documents/deno-poc/out.js:11:1

11 define("https://deno.land/[email protected]/strings/encode", ["require", "exports"], function (require, exports) {
   ^

    at file:///Users/jeroen.peeters/Documents/deno-poc/out.js:11:1
error Command failed with exit code 1.

if I bundle it to a .ts file and run it, it gets a way larger stack trace.

On?

  • MacOS Mojave
  • [email protected] (I don't think the version mismatch would cause problems here?)
@bartlomieju
Copy link
Member

@jeroenptrs how do you run it?

Have you tried: https://github.com/denoland/deno_std/blob/master/bundle/README.md?

@jeroenptrs
Copy link
Author

@bartlomieju hoo boy 😅 yes that does the trick.

I was assuming that deno out.js would take into account that it's bundled, my bad!

@kitsonk
Copy link
Contributor

kitsonk commented Jul 5, 2019

@jeroenptrs that is on the roadmap for #2475 but we didn't want to bake all of that in with the initial release of bundling.

@windows-h8r
Copy link

@jeroenptrs how do you run it?

Have you tried: https://github.com/denoland/deno_std/blob/master/bundle/README.md?

That link is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants