Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Remove URL dependencies of std for subcommands #3201

Closed
keroxp opened this issue Oct 25, 2019 · 4 comments
Closed

[cli] Remove URL dependencies of std for subcommands #3201

keroxp opened this issue Oct 25, 2019 · 4 comments
Assignees

Comments

@keroxp
Copy link
Contributor

keroxp commented Oct 25, 2019

Currently some subcommands (fmt, test, install) depends on remote codes on https://deno.land/std. These commands don't work if site is down or wrongly serve files. Actually I met this situation recently.

It is strange and undesirable. As I commented on #3168 , There may be no way to use latest std codes for the latest cli release with tag.

So I think remote dependencies for std should be removed from cli. One possible solution is including subcommand codes in cli release. Is it possible?

@kitsonk
Copy link
Contributor

kitsonk commented Oct 26, 2019

I believe it was a very intentional decision to not bloat the binary. In particular fmt is a rather huge situation. Personally I would want us to enhance the experience versus bloating the binary with some of these things. A subcommand that would ensure that all subcommands are available locally and don't require subsequent network requests, would be my suggestion of a next step. As well as failing in an informative way.

@keroxp
Copy link
Contributor Author

keroxp commented Oct 26, 2019

Anyway we should investigate how will the binary get huge by bundling those codes. If difference is around 2~3MB, we can accept changes. Especially it is strange that the latest release is not using the latest std code for subcommands even though they had been merged.

@andyfleming
Copy link
Contributor

I agree it's nice for the binary to be small, but I'd be curious as to what the size cost is of including the subcommands. It seems strange for them to not ship with them included.

@bartlomieju bartlomieju self-assigned this Feb 5, 2020
@bartlomieju
Copy link
Member

Done in #3818, #3850 and #3865

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants