Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in lock file for subcommand std modules #3427

Closed
nayeemrmn opened this issue Dec 1, 2019 · 3 comments
Closed

Built-in lock file for subcommand std modules #3427

nayeemrmn opened this issue Dec 1, 2019 · 3 comments
Assignees

Comments

@nayeemrmn
Copy link
Collaborator

nayeemrmn commented Dec 1, 2019

We obviously need SRI for the std modules used for some subcommands.

It won't suffice to just re-enable the lock flags for these subcommands and push this responsibility to users. The URLs (and the assumption of what they contain) are fixed at build time and masked from users. It only makes sense that the checksums should be built-in beside them and checked implicitly, IMO.

Related: #200.

@ry
Copy link
Member

ry commented Dec 1, 2019

@nayeemrmn I agree. I would actually prefer we were able to include that source code in the binary - but there's the problem that prettier is quite big and would increase the executable size. I think your solution of having checksums at compile time is a good intermediate step.

@kitsonk
Copy link
Contributor

kitsonk commented Dec 3, 2019

Oooh... I like this idea! 👍

@bartlomieju
Copy link
Member

bartlomieju commented Feb 11, 2020

No longer needed - deno <subcommand> does not download std modules anymore (ref #3818, #3850 and #3865(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants