-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename deno fetch subcommand to deno cache #4600
Comments
Or the other way around:
That said, I also wonder if "create a self contained binary" could be |
@kitsonk Can I work on this? |
Is there an applicable difference between Since it both downloads and compiles, we have to imagine flags that would enable disabling either (there are always tooling use cases) and |
I think |
@humancalico I think we really need more input and consensus before it gets worked on. |
I prefer |
I don't think |
@kitsonk Those sound different. |
|
@ry was about to say the same
|
Yeah, declare namespace Deno {
cache(rootModule: string, options: CompileOptions): Promise<[Deno.Diagnostics, Record<string, string]>>;
bundle(rootModule: string, options: BundleOptions): Promise<[Deno.Diagnostics, { content: string; map?: string; types?: string; }]>;
bundle(sources: Record<string, string>, options: BundleOptions): Promise<[Deno.Diagnostics, { content: string; map?: string; types?: string; }]>;
transpile(sources: Record<string, string>, options: TranspileOptions): Promise<[Deno.Diagnostics, Record<string, string>]>;
} So |
@humancalico I guess there's enough consensus now. |
Yes, the |
in Dart is: $ pub cache add or $ pub cache repair cache would make perfect sense |
Closed in #4656 |
The subcommand
deno fetch
is confusing, as it only implies partly what the subcommand actually does (and in some cases it doesn't fetch anything). What it does is parse all the dependencies of the root module, gather all the sources, and run them through the TypeScript compiler to populate the catch, but doesn't actually run the code.We are likely to utilise the
deno compile
subcommand in the future to create a self contained binary, so the only other logically semantic term we could use isdeno build
deno cache
.This could also mean we could consider renaming theDeno.compile()
API toDeno.build()
, which is effectively the same functionality asdeno fetch
today. This would also mean that we would also have logical parity withdeno bundle
andDeno.bundle()
. The one oddity is currentlyDeno.transpileOnly()
but we have talked about--no-type-check
flag (see: #4323 (comment)) and we would then want to moveDeno.traspileOnly()
to just an option ofDeno.build()
andDeno.bundle()
.The text was updated successfully, but these errors were encountered: