Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config parsing out of js/compiler.ts #5606

Closed
kitsonk opened this issue May 18, 2020 · 2 comments · Fixed by #7228
Closed

Move config parsing out of js/compiler.ts #5606

kitsonk opened this issue May 18, 2020 · 2 comments · Fixed by #7228
Labels
cli related to cli/ dir

Comments

@kitsonk
Copy link
Contributor

kitsonk commented May 18, 2020

This issue is for tracking purposes of something the core team is working on. Informed feedback is welcomed, but please think before commenting.

Moving tsconfig parsing out of compiler.ts requires a couple things:

  • Ability to parse JSONC (@dprint has it cc/ @dsherret)
  • Having default values and overrides depending on type of compile (e.g. bundle is slightly different to just plain which are also both slightly different from the runtime APIs)
  • Changing the ops to just supply a parsed JSON structure of compiler options.
@bartlomieju bartlomieju added the cli related to cli/ dir label May 19, 2020
@bartlomieju
Copy link
Member

@kitsonk
Copy link
Contributor Author

kitsonk commented Jul 25, 2020

In my refactor of the compiler branch, I have all of the parsing and processing of the tsconfig, including the ignoring the options we ignore in Rust now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants