Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno bundle produce typescript file #5781

Closed
davidcallanan opened this issue May 23, 2020 · 5 comments
Closed

deno bundle produce typescript file #5781

davidcallanan opened this issue May 23, 2020 · 5 comments
Assignees
Labels
cli related to cli/ dir suggestion suggestions for new features (yet to be agreed)

Comments

@davidcallanan
Copy link

Are there plans to support typescript output for the deno bundle command?

Are there plans to emit typescript declaration files when creating an esm bundle with deno bundle?

I think these are important features.

@bartlomieju bartlomieju added cli related to cli/ dir suggestion suggestions for new features (yet to be agreed) labels May 26, 2020
@bartlomieju
Copy link
Member

Ref #3385

As for outputting TypeScript - I'm not sure - @kitsonk WDYT?

@davidcallanan
Copy link
Author

@bartlomieju I thought the idea was that TypeScript was to be the "source of truth" and so if modules are being bundled it only makes sense to me that TypeScript output would be an option (if not a default).

Another thing that might have come up already is outputting source maps.

@kitsonk
Copy link
Contributor

kitsonk commented May 26, 2020

I don't think anyone said TypeScript is the source of truth. It is a first class language. Outputting to a TypeScript bundle is inefficient, as it would require reparsing again. Outputting the .d.ts file is just as truthful as outputting TypeScript and more efficient and subsequent consumption.

Source maps is #4499.

@pedropaulosuzuki
Copy link

Outputting typescript in bundler is great for modules. I think that option would be good as well.

@kitsonk
Copy link
Contributor

kitsonk commented Nov 8, 2020

I think the only action we would take on this is #3385. So thanks for the suggestion, but politely declined.

@kitsonk kitsonk closed this as completed Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

No branches or pull requests

4 participants