Cannot import all the files from a folder.

[Ayfri]

Hi!
I'm making a Discord bot with dynamic commands (automatic loading/reloading).
It's not my first Discord bot but all previous was made using node.js and require() to do this dynamically.
But here it doesn't work using await import() :/

Here is my code :

import {SEP} from 'https://deno.land/std/path/mod.ts';
import {configs} from './configs.ts';
// configs.commandsFolder = 'src/commands'

const cmdDir: Iterable<Deno.DirEntry> = Deno.readDirSync(Deno.realPathSync(configs.commandsFolder));
for (let command of [...cmdDir]) {
	if (command.isFile && command.name.endsWith('.ts')) {
		const path: string = Deno.realPathSync(configs.commandsFolder + SEP + command.name);
		const commandClass: any = await import(`file://${path}`);
		const cmd: any = commandClass.default;
		if (!cmd) {
			console.warn(`Could not load '${command.name}' command !`);
			continue;
		}
		commands.set(cmd.name, new cmd());
		console.log(`Successfully loaded '${cmd.name}' command !`);
	}
}

console.log(commands);

I have two commands, named CompileCommand.ts and ReloadCommand.ts, this is the code of the command reload :

import Command from '../classes/Command.ts';

export default class ReloadCommand extends Command {
	public constructor() {
		super('reload');
	}
	
	public async run(message: Message, args: string[]): Promise<void> {
		// some code
	}
}

So when I launch all this, it loads the first command but stops at the second for no reason, not sending any error (it was sending one in deno 1.4.4 and now I am in 1.4.5).
There are the logs :

Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/mod.ts
Successfully loaded 'CompileCommand' command !
Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/src/commands/ReloadCommand.ts

(tsc-bot/mod.ts is the file where there is the command handler)
I don't know what it is doing, why it does that and I want some help ^^'

[kitsonk]

@bartlomieju feels like it is related to #7549 and #7672

[bartlomieju]

Fixed in #7911

[Ayfri]

It still doesn't work :/
Now I'm getting an error but it makes no sense :

Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/mod.ts
Successfully loaded 'CompileCommand' command !
Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/src/commands/ReloadCommand.ts
error: Uncaught ReferenceError: default is not defined
		const cmd: any = commandClass.default;
		                              ^
    at mod.ts:27:33

The two commands that I have are exported the same way so it shouldn't say this 🤔

[bartlomieju]

@Ayfri this is more complex bug after all - it was fixed partially in #7672 but had to be reverted in #7911 - I will work towards fixing that in the coming days.

[Ayfri]

Okay no problem, I'll wait.

[bartlomieju]

@Ayfri could you provide a reproduction steps that I could run locally to test it on your project?

[Ayfri]

@bartlomieju I pushed the code into this repo
You can see my code to load commands into the mod.ts file.

This project is very experimental so it contains bad code ¯_(ツ)_/¯

[bartlomieju]

@Ayfri thanks! I tested #7946 on your project and it indeed hangs. I will investigate further.

[bartlomieju]

@Ayfri FYI I've fixed TLA implementation, but there's still a problem with your code - you've got circular import originating from dynamic import - when you import ReloadCommand, there an import to mod.ts, which in turns imports ReloadCommand dynamically. This will not work and would result in an error once #7946 lands - however that won't be the case in this specific example as one of your dependencies sets up timer that never resolves. I suggest to restructure your code to have collection of commands defined in one file and doing loading in a separate file.

[Ayfri]

Yes, this code was just a test and wasn't defined to be public so I will restructure everything so it will be clean and functional ^^

Thanks for fixing that, I'm waiting for the release!

[Ayfri]

Still not working in 1.5.1, still getting this in console

Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/mod.ts
Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/src/commands/CompileCommand.ts
Successfully loaded 'CompileCommand' command !
Check file:///C:/Users/Pierre/WebstormProjects/deno/tsc-bot/src/commands/ReloadCommand.ts

[kitsonk]

It isn't clear to me what isn't working. Could you provide a clearer picture of what you expect to happen and what isn't happening in 1.5.1, hopefully with a full example that could be run?

[Ayfri]

I have a directory commands that contains files and every file contains a class in it.
So I'm trying to dynamically fetch and import all the file to create an instance of all the classes.

But what I am getting is the fetch, then the import of the first file, then nothing.
And code stops being executes here, but the process continue.

You can see the code here.

[bartlomieju]

@Ayfri FYI I've fixed TLA implementation, but there's still a problem with your code - you've got circular import originating from dynamic import - when you import ReloadCommand, there an import to mod.ts, which in turns imports ReloadCommand dynamically. This will not work and would result in an error once #7946 lands - however that won't be the case in this specific example as one of your dependencies sets up timer that never resolves. I suggest to restructure your code to have collection of commands defined in one file and doing loading in a separate file.

This comment still stands - when you import mod.ts then, mod.ts is also being imported dynamically by src/commands/Reload.ts; it causes a dead lock.

[Ayfri]

Oh...
Really ?

If I move the fetching and import part from the mod.ts into another file then I just call it in the mod.ts, does it gonna work ?

[bartlomieju]

Oh...
Really ?

If I move the fetching and import part from the mod.ts into another file then I just call it in the mod.ts, does it gonna work ?

@Ayfri yes that should work, try registering commands in a separate file.

[Ayfri]

// @filename: mod.ts
import {loadCommands} from './loadCommands.ts';
[...]
export const commands = new Collection<string, Command>();
const cmdDir: Iterable<Deno.DirEntry> = Deno.readDirSync(Deno.realPathSync(configs.commandsFolder));

await loadCommands(cmdDir, commands);
console.log(commands);

// @filename: loadCommands
import {configs} from './configs.ts';
import {Collection, SEP} from './deps.ts';
import type Command from './src/classes/Command.ts';

export async function loadCommands(cmdDir: Iterable<Deno.DirEntry>, commands: Collection<string, Command>): Promise<void> {
	for (let command of [...cmdDir]) {
		if (command.isFile && command.name.endsWith('.ts')) {
			const path: string = Deno.realPathSync(configs.commandsFolder + SEP + command.name);
			const commandClass: any = await import(`file://${path}`);
			const cmd: any = commandClass.default;
			if (!cmd) {
				console.warn(`Could not load '${command.name}' command !`);
				continue;
			}
			commands.set(cmd.name, new cmd());
			console.log(`Successfully loaded '${cmd.name}' command !`);
		}
	}
}

This has the same behavior than before. 🤔

[Ayfri]

And I don't understand why does the mod.ts file is dynamically imported from the commands 🤔
I don't import it in the code.

[lucacasonato]

@Ayfri You do import it - https://github.com/Ayfri/tsc/blob/master/src/commands/ReloadCommand.ts#L3. You shouldn't move the loadCommands function into a separate file - you should move the export const commands = new Collection<string, Command>();.

[Ayfri]

Oooh, I understand now, I fixed it and it works now, thank you!
And thanks to you for your patience!