Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: std/crypto #8006

Closed
ssslambda opened this issue Oct 17, 2020 · 9 comments
Closed

Proposal: std/crypto #8006

ssslambda opened this issue Oct 17, 2020 · 9 comments

Comments

@ssslambda
Copy link

We already have bcrypt and argon2 modules on /x, it would be nice to have them in std just like in golang, also i think both of them (and others too) can be implemented via wasm for better perfomance

@crowlKats
Copy link
Member

I think before we do a std/crypto we should first have webcrypto api implemented

@ssslambda
Copy link
Author

I think before we do a std/crypto we should first have webcrypto api implemented

I don't see WebCrypto in Deno Q4 roadmap, but we need to have at least bcrypt right now, it is very popular and used to hash passwords (it is necessary for almost any Deno web server)

@timonson
Copy link
Contributor

timonson commented Oct 17, 2020

I would like to add god_crypto to the list as another third party module which tries to use WebCrypto if available.

@crowlKats
Copy link
Member

The problem is getting crypto stuff right is difficult, that is why we still dont have webcrpyto even tho it is quite important. for that same reason, i think we should hold off having something like std/crypto.
Also, the two modules you linked are written in TS & as a plugin, respectively. neither of those 2 things is ideal. the right solution would be using WASM.

@ssslambda
Copy link
Author

ssslambda commented Oct 17, 2020

The problem is getting crypto stuff right is difficult, that is why we still dont have webcrpyto even tho it is quite important. for that same reason, i think we should hold off having something like std/crypto.
Also, the two modules you linked are written in TS & as a plugin, respectively. neither of those 2 things is ideal. the right solution would be using WASM.

WASM is possible for both of them

UPD: Possible for both algorithms, not modules i linked

@crowlKats
Copy link
Member

I know it is. but the main issue remains: we dont have someone knowledgeable about cryptography.
even if we'd have such a person, webcrypto would be a higher priority.

@kitsonk
Copy link
Contributor

kitsonk commented Oct 18, 2020

The Q4 roadmap is the current priorities of the core team, it is not everything for Q4.

WebCrypto would be preferred over any std, so closing as a duplicate of #1891.

@kitsonk kitsonk closed this as completed Oct 18, 2020
@caspervonb
Copy link
Contributor

caspervonb commented Oct 18, 2020

I don't see WebCrypto in Deno Q4 roadmap

I might get to it, chime in on the original issue.

@halvardssm
Copy link

Dont mean to reopen a dormant issue, but just wanted to chime in for future reference:

@ssslambda I recently started a new project to extend Deno STD (it does not replace STD, but extends it). It encourages the addition of functionality that exists in other standard libraries (PHP, Go etc.), and also allows for functionality that benefits from being in a standard library rather than in third party modules. One example is the crypto package which provides Argon2 and Bcrypt, and other password hashes can be submitted by PR. Here is the link: https://jsr.io/@stdext/crypto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants