Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Platform Tests coverage tracking issue #9001

Closed
25 of 28 tasks
lucacasonato opened this issue Jan 5, 2021 · 12 comments
Closed
25 of 28 tasks

Web Platform Tests coverage tracking issue #9001

lucacasonato opened this issue Jan 5, 2021 · 12 comments
Labels
help wanted community help requested tests related to tests

Comments

@lucacasonato
Copy link
Member

lucacasonato commented Jan 5, 2021

In #8990 we added a WPT runner, and the entire WPT test suite to the repo. We are now able to run web platform tests. Currently only a very limited amount of tests is enabled, and many tests will fail once we enable testing them. We would like to get more coverage for our built in Web APIs. I have listed all of the suites that are potentially relevant for us below.

If you would like to enable one of these suites (and fix the resulting issues), please comment on the issue so we don't have multiple people working on the same suites.

@lucacasonato lucacasonato added tests related to tests help wanted community help requested labels Jan 5, 2021
@lucacasonato lucacasonato mentioned this issue Jan 5, 2021
22 tasks
@lucacasonato
Copy link
Member Author

I am going to start work on the URL test suite.

@lucacasonato
Copy link
Member Author

I will also take Encoding, because this being correct is a prerequisite for URL.

@nayeemrmn
Copy link
Collaborator

I am going to start work on the URL test suite.

If you're interested in looking into it, at some point we really should replace URL's implementation with rust-url since it was literally made for that for Servo/Firefox IIRC.

@lucacasonato
Copy link
Member Author

If you're interested in looking into it, at some point we really should replace URL's implementation with rust-url since it was literally made for that for Servo/Firefox IIRC.

Can you open a new issue?

@tarikeshaq
Copy link
Contributor

Hello! Pretty new here, but I can take the console tests if that's okay. I'll add the test suites and open a PR to see if we'd like to fix any failing tests!

@vishalvibes
Copy link
Contributor

@lucacasonato I would like to add wasm, I am new here, so I may take a little time!

@caspervonb
Copy link
Contributor

caspervonb commented Jan 7, 2021

So, atob seem to only have a fuzzy html test which should be patched upstream to be js.
I'll try to get it patched upstream and then enable it for us.

Same goes for timers.

@kt3k
Copy link
Member

kt3k commented Jan 12, 2021

WPT seems having the test cases for DOMExcpetion class at WebIDL/ecmascript-binding/es-exceptions/. I'd like to add it and align the API to the spec.

@satyarohith
Copy link
Member

I'm working on WebSockets.

@lucacasonato
Copy link
Member Author

@satyarohith Please hold on that until we merge #9046.

@lucacasonato
Copy link
Member Author

lucacasonato commented Jun 15, 2021

Should enable:

fetch/api/body/formdata.any.js
fetch/api/redirect/redirect-upload.h2.any.html
fetch/api/request/request-structure.any.html
fetch/api/request/request-headers.any.html
fetch/api/request/request-error.any.html
fetch/api/request/request-disturbed.any.html
fetch/api/headers/header-values.any.html
fetch/api/headers/header-values-normalize.any.html
fetch/content-length/api-and-duplicate-headers.any.html
fetch/content-encoding/bad-gzip-body.any.html

@lucacasonato lucacasonato unpinned this issue Jul 2, 2021
@crowlKats
Copy link
Member

all tasks besdies webgpu seem to have been addressed, so will close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted community help requested tests related to tests
Projects
None yet
Development

No branches or pull requests

8 participants