feat(ext/crypto): export RSA as pkcs#8 #11880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledivy
commented
Aug 31, 2021
ry
reviewed
Sep 11, 2021
| // Node, Chromium and Firefox also use rsaEncryption (1.2.840.113549.1.1.1) and do not support id-RSASSA-PSS. | ||
|
|
||
| // parameters are set to NULL opposed to what spec wants (see above) | ||
| oid: rsa::pkcs8::ObjectIdentifier::new("1.2.840.113549.1.1.1"), |
There was a problem hiding this comment.
So probably we shouldn't support it either...
There was a problem hiding this comment.
yup, that is the current behavior 👍
@lucacasonato There are. Will enable them in #11891 (cuz they depend on importKey) :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards #11690