Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ext/crypto): implement AES-GCM encryption #13119

Merged
merged 12 commits into from
Jan 5, 2022

Conversation

littledivy
Copy link
Member

@littledivy littledivy commented Dec 17, 2021

Towards #11690

Discussed on Discord, Only 96-bit nonce is supported due to type limitations until we have this lifted upstream.

@littledivy littledivy marked this pull request as ready for review December 17, 2021 10:37
ext/crypto/encrypt.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a request and a question.

ext/crypto/00_crypto.js Show resolved Hide resolved
ext/crypto/00_crypto.js Show resolved Hide resolved
@bartlomieju
Copy link
Member

@littledivy please rebase

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@littledivy littledivy merged commit c74eb7a into denoland:main Jan 5, 2022
@littledivy littledivy deleted the aes_gcm_impl branch January 5, 2022 15:12
@littledivy littledivy mentioned this pull request Jan 5, 2022
@cryptographix
Copy link
Contributor

@littledivy are you working on AES-GCM decrypt?

@littledivy
Copy link
Member Author

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants