Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1228: Skip 3 fetch tests on windows #5803

Merged
merged 7 commits into from
May 24, 2020
Merged

Issue 1228: Skip 3 fetch tests on windows #5803

merged 7 commits into from
May 24, 2020

Conversation

mitch292
Copy link
Contributor

Resolves #1228

Per issue, flaky tests are ignored on windows. Race condition is solved on other OS's.

fetch_test.ts's tests impacted:

  • fetchRequest
  • fetchPostBodyString
  • fetchPostBodyTypedArray

@bartlomieju
Copy link
Member

@mitch292 have you tried running the tests for windows as well?

@mitch292
Copy link
Contributor Author

mitch292 commented May 24, 2020 •
edited
Loading

@bartlomieju , looks like @ry removed the windows restrictions and they are passing.

ry
ry approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @mitch292 !

@ry ry merged commit 4ca0d6e into denoland:master May 24, 2020
@mitch292 mitch292 deleted the issue-1228-skip-fetch-test-windows branch May 24, 2020 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable flaky fetch tests
3 participants
@mitch292 @bartlomieju @ry