-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Worker is not a Future #7895
refactor: Worker is not a Future #7895
Conversation
This commit rewrites deno_core::JsRuntime to not implement Future trait. Instead there are two separate methods: - JsRuntime::poll_event_loop() - does single tick of event loop - JsRuntime::run_event_loop() - runs event loop to completion
This commit renames occurrences of "isolate" variable name to "js_runtime". This was outstanding debt after renaming deno_core::CoreIsolate to JsRuntime.
Welcome change from my perspective, nice to be explicit about this but a few open questions.
|
How do you propose to do that?
It would mean that |
nevermind - I see this is worker not jsruntime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit f4357f0.
This commit rewrites deno::Worker to not implement Future trait. Instead there are two separate methods: - Worker::poll_event_loop() - does single tick of event loop - Worker::run_event_loop() - runs event loop to completion Additionally some cleanup to Worker's field visibility was done.
* Revert "refactor: Worker is not a Future (denoland#7895)" This reverts commit f4357f0. * Revert "refactor(core): JsRuntime is not a Future (denoland#7855)" This reverts commit d8879fe. * Revert "fix(core): module execution with top level await (denoland#7672)" This reverts commit c7c7677.
No description provided.