Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node LTS #15

Closed
dsherret opened this issue Oct 8, 2021 · 5 comments · Fixed by #82
Closed

Support Node LTS #15

dsherret opened this issue Oct 8, 2021 · 5 comments · Fixed by #82
Labels
enhancement New feature or request

Comments

@dsherret
Copy link
Member

dsherret commented Oct 8, 2021

Running this example:

const { Deno } = require("deno.ns");

I get the following in Node v14.17.1:

> node test.js
node_modules\deno.ns\dist\deno\stable\classes\PermissionStatus.js:7
class PermissionStatus extends EventTarget {
                               ^

ReferenceError: EventTarget is not defined
    at Object.<anonymous> (node_modules\deno.ns\dist\deno\stable\classes\PermissionStatus.js:7:32)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:14)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:92:18)
    at Object.<anonymous> (node_modules\deno.ns\dist\deno\stable\classes\Permissions.js:5:31)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)

This is because EventTarget was not a global until node v15 I think (works in 16). Current LTS version of node is v14. We should try to support at least Node LTS.

@dsherret dsherret added the enhancement New feature or request label Oct 8, 2021
@MKRhere
Copy link
Contributor

MKRhere commented Oct 9, 2021

If EventTarget is the only blocker, we could polyfill it.

@MKRhere
Copy link
Contributor

MKRhere commented Oct 9, 2021

Alternatively, node 16 is active LTS from end of this month (October 26th). Since deno.ns might not be "stable" for a few weeks even by the most optimistic estimate, it might not be so bad to only support active LTS from then (node 16).

@wojpawlik
Copy link
Contributor

@wojpawlik
Copy link
Contributor

@bartlomieju
Copy link
Member

Node v14 goes into maintenance period today and Node v16 becomes LTS in a week https://nodejs.org/en/about/releases/

I think we should focus on v16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants