Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web sockets. #29

Closed
ry opened this issue Dec 19, 2018 · 7 comments
Closed

Web sockets. #29

ry opened this issue Dec 19, 2018 · 7 comments

Comments

@ry
Copy link
Member

ry commented Dec 19, 2018

No description provided.

@keroxp
Copy link
Contributor

keroxp commented Dec 29, 2018

https://github.com/keroxp/deno-ws

Hi, I created an experimental websocket server with deno.
I hope this is useful for you.

Thanks.

@ry
Copy link
Member Author

ry commented Jan 3, 2019

@keroxp How well is it working? Can you give us a status update? What are the major missing features? Would you be open to including that in deno_std?

@keroxp
Copy link
Contributor

keroxp commented Jan 3, 2019

@ry There are no major missing features from server-side point of view. WebSocket server based on RFC 6455 works fine.

However WebSocket client for deno runtime hasn't been implemented because there are no way(?) to open HTTP connection for upgrading to websocket, fetch() api doesn't suit this purpose.

Minor missing features are some websocket extension protocol handler (e.g. permessage deflate).
But their implementation may be optional. WebSocket client that is written by Node.js (wscat, by ws)could connect to the server that running on deno.

Would you be open to including that in deno_std?

Yes! I hope that it will be merged into deno_std, if you plan to place WebSocket API on deno's standard library.

@ry
Copy link
Member Author

ry commented Jan 3, 2019

However WebSocket client for deno runtime hasn't been implemented because there are no way(?) to open HTTP connection for upgrading to websocket, fetch() api doesn't suit this purpose.

You can use deno.dial() ... but it won't work over https. I've been considering to reimplement fetch using deno.dial() once we can support TLS.

Yes! I hope that it will be merged into deno_std, if you plan to place WebSocket API on deno's standard library.

Great! Can you prepare a PR?

@keroxp keroxp mentioned this issue Jan 4, 2019
Merged
@keroxp
Copy link
Contributor

keroxp commented Jan 4, 2019

@ry I opened PR for websocket. Please review it!

@keroxp
Copy link
Contributor

keroxp commented Feb 20, 2019

@ry Can be closed?

@ry
Copy link
Member Author

ry commented Feb 20, 2019

@ry ry closed this as completed Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants