Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving deno testPerm and unit_test_runner to std library #418

Closed
bartlomieju opened this issue May 19, 2019 · 1 comment
Closed

Comments

@bartlomieju
Copy link
Member

Once we get support for import() and start working on more concrete test runner I suggest we should consider introducing testPerm function and logic from unit_test_runner to standard library.

Rationale:
Since we have Deno.permissions() API it's crucial to test applications with different set of permission and I believe we should support it as first class citizen.

I decided to open this issue because I hit problem described above (need to test library with and without --allow-env) and don't to want copy runner code just to my repo.

testPerm(perms: TestPermissions) and spawning new Deno process for each combination of discovered permissions is working fine in main repo so we might start out from there and work toward better implementation as needed.

@bartlomieju
Copy link
Member Author

This issue should be revisited after landing test runner #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant